Pierce Lopez

Results 269 comments of Pierce Lopez

This fix looks good. Unfortunately, this repo no longer has any maintainers, sorry.

(there is a minor additional build fix at https://github.com/ploxiln/dablooms and I would be happy to merge this fix there)

There is indeed a function exposed to clean up all connection pool resources, typically before one's program exits, but it's not convenient to detect and handle quiet times and free...

It would be better to actually build from local source with local go. If this is done by the maintainers as they make a release, it will be equivalent to...

I think debian ca-certificates is fine. Getting it from a docker image that contains just the ca-certificates is a bit odd (but would work). Another option is to download directly...

That is roughly what I had in mind, thanks. As another example, `dist.sh` for nsq runs "docker build" itself: https://github.com/nsqio/nsq/blob/master/dist.sh

Curl's website does look like a good source for such a CA bundle. It's probably equivalent to what is currently being fetched from the Certifi project. Interestingly, that page says:...

The openshift fork https://github.com/openshift/oauth-proxy has already been mentioned. I've started a humble and initially somewhat minimal fork myself, and I've made a release: https://github.com/ploxiln/oauth2_proxy/releases

> 2017/11/01 03:31:43 oauthproxy.go:163: Cookie settings: name:test secure(https):true ... > 2017/11/01 03:31:52 oauthproxy.go:272: Warning: request host is "127.0.0.1" but using configured cookie domain of "127.0.0.1.xip.io:4180" > 2017/11/01 03:31:52 cookie.go:168: net/http:...