nivo icon indicating copy to clipboard operation
nivo copied to clipboard

feat(sunburst): add innerRadius and renderRootNode props

Open uson1x opened this issue 1 year ago • 5 comments

Hey

Thank you for your great work on this library.

I saw a few innerRadius sunburst PRs and decided to make a fresh version with a storyboard for you.

Please, let me know if you need to change anything in order to get this PR to be ready to be merged. I'd be happy to rewrite the PR as needed.

Right now we are pressed to use a custom version of nivo because in our project we need to control the innerRadius, but it would be so much easier to work with if it was in the main repository.

Thank you for taking a look at it!

Fixes https://github.com/plouc/nivo/issues/1649

PS: to give credit, this is based on https://github.com/plouc/nivo/pull/2219

uson1x avatar Mar 06 '25 11:03 uson1x

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nivo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2025 9:07pm
nivo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2025 9:07pm

vercel[bot] avatar Mar 06 '25 11:03 vercel[bot]

@uson1x, I reviewed the previous PR as it already came from another PR 😅 I think you could submit a PR once the other one is merged, with the added story.

plouc avatar Mar 16 '25 05:03 plouc

As the previous one seems inactive, we should probably go for yours instead.

plouc avatar Apr 14 '25 13:04 plouc

@uson1x is attempting to deploy a commit to the plouc's projects Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar May 13 '25 14:05 vercel[bot]

@uson1x, I think you forgot to run make fmt.

plouc avatar May 13 '25 21:05 plouc