nivo icon indicating copy to clipboard operation
nivo copied to clipboard

@nivo/rects and @nivo/icicles package

Open lsagetlethias opened this issue 3 years ago • 6 comments

image image

Highly inspired from @nivo/sunburst, @nivo/arcs, and https://observablehq.com/@d3/zoomable-icicle.

The main goal was to add a "flat" version of the Sunburst chart.

This PR is pretty complete but some TODO remains which are not critical and I don't know how to resolve them for now:

  • @nivo/rects:
    • [ ] Add transition mode like what's arcs package has builtin
    • [ ] Create a useAnimatedRect hook for single rect animation
  • @nivo/icicles
    • [ ] Figure out why text colors (e.g. "white", "black") are not working with borderColor props (react-spring is during useTransition with text spring values I guess?)
    • [ ] Canvas version
  • website
    • [ ] add icons and captures for Icicles

@plouc Tell me if anything is missing.

Shout out to my buddy and co author of this packages: @mehdilouraoui.

lsagetlethias avatar Apr 22 '22 18:04 lsagetlethias

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5708279292adc19f9e13c49a5d3ab70df4999376:

Sandbox Source
nivo Configuration

codesandbox-ci[bot] avatar Apr 22 '22 18:04 codesandbox-ci[bot]

ping @plouc don't hesitate if you need some help for review or merge

lsagetlethias avatar Apr 27 '22 12:04 lsagetlethias

@lsagetlethias, I'll try to review it in the upcoming weeks, sorry for the delay.

plouc avatar May 10 '22 13:05 plouc

Great news! Don't hesitate if you want to live pair-review (in english or french), I can make myself available around your TZ.

lsagetlethias avatar May 10 '22 13:05 lsagetlethias

Hello @plouc , any update on this?

lsagetlethias avatar Jun 20 '22 08:06 lsagetlethias

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

stale[bot] avatar Sep 20 '22 16:09 stale[bot]

bump

lsagetlethias avatar Sep 20 '22 17:09 lsagetlethias

Still revelant

lsagetlethias avatar Dec 21 '22 23:12 lsagetlethias