go-gitlab-client icon indicating copy to clipboard operation
go-gitlab-client copied to clipboard

Published 20 hours ago • verified publisher icon plouc

RepoCommits() missing parameter

Open leiyue1989 opened this issue 4 years ago • 3 comments

param I want the commit under the branch of this project, but this method does not have a second argument

What am I supposed to do ?

leiyue1989 avatar Aug 26 '20 11:08 leiyue1989

I can't find this function. Could you link the file you found it in?

edison-moreland avatar Aug 26 '20 15:08 edison-moreland

Okay, I found it in the v1 branch.

It looks like the refname param was just never added and the whole function disappeared with v2. Thankfully, it should be really easy to add. I'll start adding this now on my fork.

edison-moreland avatar Aug 26 '20 15:08 edison-moreland

I've added RefName to the CommitOptions object so that you can use the ProjectCommits function. Here is my change: https://github.com/edison-moreland/go-gitlab-client/blob/v3/gitlab/commits.go#L97

You'll need to switch to the v3 branch of my fork.

Let me know if you have any issues

edison-moreland avatar Aug 26 '20 15:08 edison-moreland