react-pivottable icon indicating copy to clipboard operation
react-pivottable copied to clipboard

Default value for `aggregatorName`

Open PierreMarion23 opened this issue 7 years ago • 2 comments

Hi, In your documentation, you write that the aggregatorName key should take as default value the first key in aggregators, but in the code (Utilities.js, line 777), the default value is Count. This is annoying when defining custom aggregators, because the Count aggregator is not necessarily in the aggregator list, and you don't always want to specify a aggregatorName key, thus leading to an error. So in my opinion, it would be better to have this default value as specified in the documentation :).

Many thanks, Pierre

PierreMarion23 avatar Apr 01 '18 13:04 PierreMarion23

Good point! I'll see when I have time to do this, and I'd happily accept a PR for it :)

nicolaskruchten avatar Apr 16 '18 17:04 nicolaskruchten

Is there any update on this?

debikadutt avatar Feb 25 '19 17:02 debikadutt