react-pivottable icon indicating copy to clipboard operation
react-pivottable copied to clipboard

Implementation issue of valueFilter?

Open aboulang opened this issue 3 years ago • 0 comments

I think this may be an implementation issue. From what I can tell the intent was for

var valueFilter = {"Colors":{"Green": true}};

to do what gmacias711 expected in https://github.com/plotly/react-pivottable/issues/68. Looks like Nicolas merged inclusions and exclusions parameters from pivotable.js (see https://github.com/nicolaskruchten/pivottable/wiki/Parameters about Pivotable.js's inclusions and exclusions parameters ) into one valueFilter but it is not handling the inclusions side correctly. It can be cumbersome to have to collect all the exclusions instead of what should be included -- especially if valueFilter is a prop that currently can not be modified! The true value not working as expected and therefore having to collect all the values to set to false when the Pivotable is first created is biting me.

Originally posted by @aboulang in https://github.com/plotly/react-pivottable/issues/68#issuecomment-1179590033

aboulang avatar Jul 09 '22 19:07 aboulang