react-cytoscapejs icon indicating copy to clipboard operation
react-cytoscapejs copied to clipboard

Add TypeScript typings

Open ryanberckmans opened this issue 4 years ago • 6 comments

Could you please add TypeScript typings to this repo or to a new @types/react-cytoscapejs package?

Looks like someone already wrote them https://github.com/manuc66/react-cytoscapejs-typescript-sample/blob/master/typings/react-cytoscapejs.d.ts

ryanberckmans avatar Nov 04 '19 21:11 ryanberckmans

That typing set is not good enough - it doesn't contain the typing details for CytoscapeComponent.normalizeElements, so the user can't call the function when using TypeScript

PeterJFerrarotto avatar Nov 07 '19 19:11 PeterJFerrarotto

CytoscapeComponent.normalizeElements and other properties are now present in the definition, see: https://github.com/manuc66/react-cytoscapejs-typescript-sample/blob/master/typings/react-cytoscapejs.d.ts

manuc66 avatar Nov 28 '19 23:11 manuc66

@manuc66, would you please add your definition to DefinitelyTyped?

There are instructions here: https://definitelytyped.org/guides/contributing.html

maxkfranz avatar Dec 02 '19 16:12 maxkfranz

Here is the PR : DefinitelyTyped/DefinitelyTyped#45577

manuc66 avatar Jun 18 '20 21:06 manuc66

The PR has been merged

manuc66 avatar Jun 23 '20 21:06 manuc66

#close

manuc66 avatar Feb 26 '21 16:02 manuc66