Use modern `native ES6 import` to load plotly.js bundle instead of `requirejs` which is no longer under active development
This removes references in the base renderers to requirejs. Requirejs is essentially unmaintained and newer versions of jupyter lab and jupyter notebook don't support it anymore, so this fixes some of the notebook 7 and lab 4 issues we've been seeing. Replaces requirejs support with native javascript modules: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Modules
Alternative to #4762 that doesn't remove the CDN.
Fixes #4336.
Great PR. Please add a changelog also please mention if it is fixing #4336?
Note: the orca tests are also failing on master
Please update the description of the PR and include links & info about requirejs.
@LiamConnors do you have permission to merge this?
@marthacryan and @archmoj, when building Plotly.py using this PR and the master branch of Plotly.js, figures don't load in a classic notebook and the following error is in the console.
@archmoj @marthacryan please sync with @LiamConnors about the issue he flagged (previous comment in this thread)
Regarding the error saw in my previous comment. It only is an issue with notebook<7
Is there any blocker for merging this PR?
Is there any blocker for merging this PR?
@archmoj @LiamConnors @gvwilson I believe there isn't anything blocking merging since Liam was able to use this with Notebook 7.
:dancer:
merge it!