plotly.js icon indicating copy to clipboard operation
plotly.js copied to clipboard

Fix #7387: Specify buffers in regl.clear() to avoid performance warning

Open MzyzzG opened this issue 10 months ago • 1 comments

This PR fixes issue #7387 by specifying the color and depth buffers in the regl.clear() call in src/traces/scattergl/plot.js. This prevents the "Performance warning: clear() called with no buffers in bitmask" warning.

Changes:

  • Modified regl.clear({}) to regl.clear({ color: true, depth: true }).

MzyzzG avatar Mar 16 '25 01:03 MzyzzG

This PR looks good to me. 💯 🙏 Many thanks @zachchan-voltaiq Thanks to @emilykl's https://github.com/plotly/plotly.js/pull/7396 and in order for the failing tests to pass you could fetch upstream/master and merge it into your PR branch.

Please add a draft log as described here: https://github.com/plotly/plotly.js/tree/master/draftlogs

Also it would be great if you add a jasmine test possibly in test/jasmine/tests/scattergl_test.js to lock the bug you fixed in this PR.

Thank you!

archmoj avatar Apr 03 '25 14:04 archmoj

:dancer:

archmoj avatar Jul 07 '25 15:07 archmoj