plotly.R icon indicating copy to clipboard operation
plotly.R copied to clipboard

Drop dependency on lazyeval

Open olivroy opened this issue 7 months ago • 1 comments

A fix was inspired by the fix here https://github.com/tidyverse/ggplot2/pull/2797/files.

I fixed small docs issues + updated the link to the repo.

Edit: seealso https://github.com/rstudio/ggvis/pull/488/files

olivroy avatar Nov 23 '23 20:11 olivroy

Can't replicate most test failures locally.

This fails in CI (both locally and on GHA), but when I try running it manually, it works fine.

test_that("doesn't break old behavior", {
  # from https://community.plot.ly/t/manual-color-bug/10479
  density1 <- density(diamonds[diamonds$cut %in% "Fair", ]$carat)
  density2 <- density(diamonds[diamonds$cut %in% "Ideal",]$carat)
  
  l <- plot_ly(x = ~density1$x, y = ~density1$y, type = 'scatter', mode = 'lines', name = 'Fair cut', fill = 'tozeroy',
          fillcolor = 'rgba(168, 216, 234, 0.5)',
          line = list(width = 0.5)) %>%
    add_trace(x = ~density2$x, y = ~density2$y, name = 'Ideal cut', fill = 'tozeroy',
              fillcolor = 'rgba(255, 212, 96, 0.5)') %>%
    plotly_build()
  
  
  expect_equal(l$x$data[[1]]$name, "Fair cut")
  expect_equal(l$x$data[[2]]$name, "Ideal cut")
})

olivroy avatar Nov 23 '23 20:11 olivroy