graphing-library-docs icon indicating copy to clipboard operation
graphing-library-docs copied to clipboard

Update title check to `page.permalink`

Open LiamConnors opened this issue 3 years ago • 2 comments

I think all of these should be page.permalink,

LiamConnors avatar Dec 13 '22 20:12 LiamConnors

That doesn't seem right... why? This will only display the proper title if you land directly on /python/ but not any sub pages?

nicolaskruchten avatar Dec 14 '22 14:12 nicolaskruchten

The other pages are captured by the last condition:

{% elsif page.name %} {{page.name | capitalize}} in {{language}}{% else %} Plotly Open Source Graphing Libraries{% endif %}

Right now for any non-Python language index page it shows something like this:

image

So it seems those page titles are being created by that last condition too

But with this change we don't repeat the language and it shows like this:

image

Which is how it currently configured for Python

LiamConnors avatar Dec 14 '22 15:12 LiamConnors