dash-table icon indicating copy to clipboard operation
dash-table copied to clipboard

Handle null value safely in case-insensitive filter

Open xwk opened this issue 3 years ago • 3 comments

Fix the issue described in https://github.com/plotly/dash-table/issues/934

Basically if the value is null, return empty string directly instead of call .toString()

xwk avatar Aug 11 '21 06:08 xwk

I have this same issue on dash 2.8.1. @alexcjohnson or other maintainer, could you review this?

zekeshearer avatar Mar 10 '23 01:03 zekeshearer

Oh thanks @zekeshearer - I had missed this PR as this repo is obsolete. I think perhaps it was created right around when we merged Dash Table into the main Dash repo.

So we can recreate it in the Dash repo. Definitely we should fix this, but I’m not sure if empty string is the right fallback, would we be better off leaving it as its non-string value so it doesn’t match an explicit empty string?

Lastly it deserves a test case.

alexcjohnson avatar Mar 10 '23 02:03 alexcjohnson

Hi, this appears to still be an issue. Is it being addressed elsewhere?

bparzonz avatar Feb 01 '24 22:02 bparzonz