dash-daq icon indicating copy to clipboard operation
dash-daq copied to clipboard

Published 20 hours ago • verified publisher icon plotly

Make thermometer measurement surface flatter.

Open shammamah-zz opened this issue 4 years ago • 6 comments

Closes #64.

Screen Shot 2019-10-16 at 10 08 11 AM Screen Shot 2019-10-16 at 10 11 31 AM

shammamah-zz avatar Oct 16 '19 13:10 shammamah-zz

Can I see some before/after screenshots?

alexcjohnson avatar Oct 16 '19 14:10 alexcjohnson

@alexcjohnson Just added them to the original comment!

shammamah-zz avatar Oct 16 '19 14:10 shammamah-zz

Thanks! Definitely a big improvement, I just wonder if it needs any radius at all. If it were completely square does it look bad or compromise it in some way?

alexcjohnson avatar Oct 16 '19 14:10 alexcjohnson

Nope, we can make it totally flat. I'll do that right now!

shammamah-zz avatar Oct 16 '19 14:10 shammamah-zz

@alexcjohnson Looks like if you make it totally flat (or with a different border radius), it no longer fits in the thermometer container:

Screen Shot 2019-10-16 at 11 04 29 AM

shammamah-zz avatar Oct 16 '19 15:10 shammamah-zz

@shammamah Might just need to tweak the container's style so that overflow is hidden.

Marc-Andre-Rivet avatar Jan 22 '20 15:01 Marc-Andre-Rivet