dash-daq icon indicating copy to clipboard operation
dash-daq copied to clipboard

Some packaging details

Open moorepants opened this issue 5 years ago • 4 comments

I've packaged this at conda forge and here are a few issues:

  • The PyPi package name is "dash-daq" but the tarball on PyPi is named "dash_daq". It is typical convention for these names to be the same.
  • The setup.py file does not include a list of dependencies, yet this package does depend on dash and other dash packages. setuptools and pip look for the dependencies by default in the setup.py file and conda forge checks this automatically on updates so we can keep the packages synced with PyPi. IT would be helpful for us (and likely users) if those were included in the setup.py file.
  • The license file is not packaged in the tarball on PyPi. This can be done using a MANIFEST.in file.
  • There are no Github releases (tags) for versions greater than 0.0.3. The tags are helpful for downstream packagers to detect differences in versions. PyPi indicates version 0.0.6 is the only version and it is difficult to see how that matches this repository.
  • The changelog does not seem to reflect the current state of the releases.
  • The setup.py file is missing many common entries that are used by PyPi and other downstream software. It would be helpful to have the standard items (descriptions, etc).

Conda forge pr: https://github.com/conda-forge/staged-recipes/pull/7613

moorepants avatar Jan 21 '19 00:01 moorepants

@moorepants Going through some old issues and I think most of these should be fixed now (I think only the release tags are missing, but we can use those moving forward). Please let me know if anything else needs to be done!

shammamah-zz avatar Jul 30 '19 20:07 shammamah-zz

Thanks. I'll check over things on the next release of dash-daq when I'm updating the conda forge package and let you know.

moorepants avatar Jul 30 '19 21:07 moorepants

Just noting that the release tags are still not used.

moorepants avatar Sep 26 '19 20:09 moorepants

@moorepants The latest release should have a release tag now. We'll be using them from now on, as well.

shammamah-zz avatar Oct 04 '19 20:10 shammamah-zz