dash-daq icon indicating copy to clipboard operation
dash-daq copied to clipboard

Visual bugs found in DDK Docs for DAQ

Open luiztauffer opened this issue 2 years ago • 3 comments

Some visual bugs that should still be fixed (@vinicvaz)

  • [x] Boolean switch vertical overlaps with label: image

  • [ ] Slider bar transparent (both light/dark modes): image

  • [ ] LED Display background for Dark mode: image

luiztauffer avatar Sep 23 '21 11:09 luiztauffer

Solution Preview:

issue 153

Code:

app.layout = html.Div(
    [
            html.Div(
                [html.H2("Switch Issue 153", className="text-center")], className="row"
            ),
            html.Div(
                daq.BooleanSwitch(
                    id="my-switch-1", on=True, label="Vertical", vertical=True
                ),
                className="row",
            ),
            html.Div(
                [html.H2("Slider Issue 153", className="text-center")], className="row"
            ),
            html.Div(daq.Slider(vertical=True), className="row"),
            html.Div(
                [html.H2("Slider Issue Dark mode 153", className="text-center")],
                className="row",
            ),
            html.Div(
                daq.DarkThemeProvider(daq.Slider(vertical=True), theme={"dark": True}),
                className="row",
            ),
            html.Div(
                [
                    html.H2(
                        "LED Display Backgroun for darkmode Issue 153",
                        className="text-center",
                    )
                ],
                className="row",
            ),
            html.Div(
                daq.DarkThemeProvider(
                    daq.LEDDisplay(
                        value="3.14159",
                    ),
                    theme={"dark": True},
                ),
                className="row",
            ),
    ]
)

Karan-S-Mittal avatar Sep 29 '21 13:09 Karan-S-Mittal

hey @Karan-S-Mittal , that looks good! But this is not being controlled by DDK, instead it is being defined by daq.DarkThemeProvider, right? What we would like it for DDK to change those color properties, from slider and LEDDisplay

luiztauffer avatar Sep 29 '21 13:09 luiztauffer

ok, I will make a example with that and see if it doesn't give any bugs.

Karan-S-Mittal avatar Sep 29 '21 13:09 Karan-S-Mittal