dash-cytoscape icon indicating copy to clipboard operation
dash-cytoscape copied to clipboard

implements wheelSensitivity feature #97

Open kinimesi opened this issue 3 years ago • 1 comments

About

Description of changes

Pre-Merge checklist

  • [x] The project was correctly built with npm run build:all.
  • [ ] If there was any conflict, it was solved correctly.
  • [ ] All changes were documented in CHANGELOG.md.
  • [ ] All tests on CircleCI have passed.
  • [ ] All Percy visual changes have been approved.
  • [ ] Two people have :dancer:'d the pull request. You can be one of these people if you are a Dash Cytoscape core contributor.

Reference Issues

Closes #[issue number]

Other comments

kinimesi avatar Aug 19 '21 17:08 kinimesi

This feature is exposes wheelSensitivity option which is one of the initialization parameters of the Cytoscape.js. This is very similar to the other initialization parameters that dash-cytoscape already has such as zoom, minZoom, userZoomingEnabled and etc. We do not have tests or demos for such features. I don't think that one is necessary for wheelSensitivity either.

It's very obvious to use and one line description was added to the relevant files in the PR (all other similar options also have one line descriptions).

kinimesi avatar Sep 21 '21 06:09 kinimesi

Just to mention I'd very much like this feature. Is there any reason why this PR got stalled?

alimanfoo avatar Oct 12 '22 11:10 alimanfoo

I await this functionality with the greatest anticipation.

ivolake avatar Dec 14 '23 12:12 ivolake

Done in #203

alexcjohnson avatar Jan 26 '24 21:01 alexcjohnson