angular-plotly.js icon indicating copy to clipboard operation
angular-plotly.js copied to clipboard

Support Ivy Distribution

Open chuma2150 opened this issue 4 years ago • 1 comments

When installing packages with latest angular v13, a warning is popping up: Processing legacy "View Engine" libraries:

  • angular-plotly.js [module/esm2015] () Encourage the library authors to publish an Ivy distribution. Thea reason for this is: https://blog.angular.io/angular-v13-is-now-available-cce66f7bc296 Refer to point "State of View Engine"

chuma2150 avatar Nov 22 '21 08:11 chuma2150

I am also getting the following warning among others while compiling:

$ ng build -c demo
⠙ Generating browser application bundles (phase: setup)...Processing legacy "View Engine" libraries:
...
- angular-plotly.js [es2015/esm2015] ()
...
Encourage the library authors to publish an Ivy distribution.
✔ Browser application bundle generation complete.
✔ Copying assets complete.
✔ Index html generation complete.

Env:

$ ng version

     _                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/
    

Angular CLI: 13.2.2
Node: 14.17.0
Package Manager: npm 7.20.5
OS: linux x64

Angular: 13.2.1
... animations, cdk, common, compiler, compiler-cli, core, forms
... language-service, material, platform-browser
... platform-browser-dynamic, router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1302.2
@angular-devkit/build-angular   13.2.2
@angular-devkit/core            13.2.2
@angular-devkit/schematics      13.2.2
@angular/cli                    13.2.2
@angular/flex-layout            13.0.0-beta.36
@schematics/angular             13.2.2
rxjs                            6.6.7
typescript                      4.4.4
$ npm list angular-plotly.js
...
└── [email protected]

Thanks

ciukstar avatar Feb 03 '22 18:02 ciukstar

Any progress so far ? Same here.

alpayoguz avatar Dec 16 '22 11:12 alpayoguz

Getting this error:

export declare class PlotlyViaCDNModule {
                           ~~~~~~~~~~~~~~~~~~
    This likely means that the library (angular-plotly.js) which declares PlotlyViaCDNModule has not been processed correctly by ngcc, or is not compatible with Angular Ivy. Check if a newer version of the library is available, and update if so. Also consider checking with the library's authors to see if the library is expected to be compatible with Ivy.

Zaffer avatar Dec 16 '22 13:12 Zaffer

This is getting urgent as Angular will remove the Angular Compatibility Compiler (ngcc) in version 16:

https://github.com/angular/angular/pull/49101

Anything I can do to help the process along?

Abildtoft avatar Mar 10 '23 12:03 Abildtoft

@chuma2150 @ciukstar @Abildtoft @alpayoguz @Zaffer I have opened a PR to fix this issue. Please feel free to review if anyone of you are a contributor.

I hope the contributors review and merge it soon.

rk-7 avatar Mar 29 '23 09:03 rk-7