plop icon indicating copy to clipboard operation
plop copied to clipboard

chore: switch from globby to tinyglobby

Open benmccann opened this issue 1 year ago • 2 comments

closes https://github.com/plopjs/plop/issues/454

benmccann avatar Oct 15 '24 04:10 benmccann

@crutchcorn just gently checking in on this. Thanks!

benmccann avatar May 20 '25 21:05 benmccann

@benmccann has now mastered skill "patience". Let's reward him now @crutchcorn, shall we?

stefanahman avatar Jul 28 '25 14:07 stefanahman

Thanks @crutchcorn for trying to update this PR. I see you pushed a few commits to it a couple of weeks ago to try to update tinyglobby to the latest. Unfortunately it left it with some merge conflicts that seemed hard to fix. I dropped those commits and tried again. I think we should now be on the latest version of tinyglobby and all merge conflicts should be addressed, so hopefully this can get another look now

benmccann avatar Sep 15 '25 16:09 benmccann

We have some failing tests, which is why I never merged after pushing to this branch :(

Unfortunately, I don't have time to investigate much more than this

crutchcorn avatar Sep 15 '25 16:09 crutchcorn

Ah, thanks. I wasn't aware! Sorry about that. I'll try to take a look later on. Leaving a comment here with the failures in case the log expires before I get back to this:

  ⎯⎯⎯⎯⎯⎯⎯ Failed Tests 7 ⎯⎯⎯⎯⎯⎯⎯
  
  
   FAIL  tests/addMany-action-transform-function/addMany-action-transform-function.spec.js > addMany-action-transform-function > addMany action without transform function
  AssertionError: expected false to be true // Object.is equality
  
   ❯ tests/addMany-action-transform-function/addMany-action-transform-function.spec.js:37:38
       37|     expect(fs.existsSync(filePath1)).toBe(true);
         |                                      ^
  
  ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/7]⎯
  
   FAIL  tests/addMany-action-transform-function/addMany-action-transform-function.spec.js > addMany-action-transform-function > addMany action transform function
  AssertionError: expected false to be true // Object.is equality

   ❯ tests/addMany-action-transform-function/addMany-action-transform-function.spec.js:60:38
       60|     expect(fs.existsSync(filePath1)).toBe(true);
         |                                      ^
  
  ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[2/7]⎯
  
   FAIL  tests/addMany-action-transform-function/addMany-action-transform-function.spec.js > addMany-action-transform-function > addMany action async transform function
  AssertionError: expected false to be true // Object.is equality
  
   ❯ tests/addMany-action-transform-function/addMany-action-transform-function.spec.js:83:38
       83|     expect(fs.existsSync(filePath1)).toBe(true);
         |                                      ^
  
  ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[3/7]⎯
  
   FAIL  tests/addMany-action-transform-function/addMany-action-transform-function.spec.js > addMany-action-transform-function > addMany action transform error
  AssertionError: expected false to be true // Object.is equality
  
   ❯ tests/addMany-action-transform-function/addMany-action-transform-function.spec.js:103:33
      103|     expect(failures.length > 0).toBe(true);
         |                                 ^
  
  ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[4/7]⎯
  
   FAIL  tests/addMany-action-transform-function/addMany-action-transform-function.spec.js > addMany-action-transform-function > addMany action async transform rejection
  AssertionError: expected false to be true // Object.is equality
  
   ❯ tests/addMany-action-transform-function/addMany-action-transform-function.spec.js:123:33
      123|     expect(failures.length > 0).toBe(true);
         |                                 ^
  
  ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[5/7]⎯
  
   FAIL  tests/addMany-action-transform-function/addMany-action-transform-function.spec.js > addMany-action-transform-function > addMany action async transform returns undefined
  AssertionError: expected false to be true // Object.is equality

   ❯ tests/addMany-action-transform-function/addMany-action-transform-function.spec.js:143:33
      143|     expect(failures.length > 0).toBe(true);
         |                                 ^
  
  ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[6/7]⎯
  
   FAIL  tests/addMany-action-transform-function/addMany-action-transform-function.spec.js > addMany-action-transform-function > addMany action async transform returns invalid
  AssertionError: expected false to be true // Object.is equality
  
   ❯ tests/addMany-action-transform-function/addMany-action-transform-function.spec.js:164:35
      164|     expect(failures.length === 1).toBe(true);
         |                                   ^

  ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[7/7]⎯

benmccann avatar Sep 15 '25 17:09 benmccann

Closing in favor of https://github.com/plopjs/plop/pull/480

benmccann avatar Sep 21 '25 23:09 benmccann