plop icon indicating copy to clipboard operation
plop copied to clipboard

Empty checkbox bypass

Open bradgarropy opened this issue 3 years ago • 2 comments

In order to address #345 I added a check for an empty value in the checkbox bypass.

    if (v === "") {
      return [];
    }

I think this solves the issue, but I haven't been able to test it from the top level. Is there another test file that I'm missing?

/cc @amwmedia @crutchcorn

bradgarropy avatar Aug 30 '22 02:08 bradgarropy

Oh, nice, this was an easy fix! :D

I would love to test this from an e2e level before we merge. Would you be comfortable making that change?

Namely, I think this file would be a good place to put it:

https://github.com/plopjs/plop/blob/main/packages/plop/tests/input-processing.spec.js

Happy to pair-code to make this happen :) Let me know how I can help

crutchcorn avatar Aug 30 '22 05:08 crutchcorn

Just pushed some additional tests for checkbox bypassing!

bradgarropy avatar Aug 31 '22 02:08 bradgarropy

having issues inputting "" inside cli eg gen hook "useHook" "" as shell is automatically removing empty strings

DawidWraga avatar Apr 05 '23 13:04 DawidWraga