jupysql icon indicating copy to clipboard operation
jupysql copied to clipboard

general CI cleanup

Open edublancas opened this issue 1 year ago • 2 comments

we have some minor issues in our CI that we need to fix:

  • update documentation for this file it says it's for Snowflake but it's also for redshift. we need to give a quick check and ensure the documentation at the top of the file is accurate
  • the github actions files are a bit inconsistent and inaccurate, let's see if we can come up with better names
  • address this issue

edublancas avatar Jan 25 '24 03:01 edublancas

Adding a note: clickhouse-sqlalchemy supports sqlalchemy > 2 : https://github.com/xzkostyan/clickhouse-sqlalchemy/blob/c5eda6dd5cb621684e56af4abd3de4c8e000f965/setup.py#L99

But the docker image is probably not supporting (need to check this).

neelasha23 avatar Jan 25 '24 05:01 neelasha23

the docker image only has clickhouse installed so my guess is that it should be independent from the sqlalchemy version

unless they had to make changes to clickhouse for sqlalchemy 2.x to work, but I doubt it. but let me know what you find!

edublancas avatar Jan 25 '24 05:01 edublancas