volto icon indicating copy to clipboard operation
volto copied to clipboard

Only include the original image in the Image component if the image does not have all the scales present. Fixed and update tests.

Open sneridagh opened this issue 1 month ago • 6 comments

Follow up: #7486 (Seven PR):

  • [ ] Add a default scale size which is large enough to serve full-width images on a large high-DPI monitor -> https://github.com/plone/plone.volto/pull/205
  • [ ] Fix the image field serializer in plone.restapi to include the same scales as the code which creates image_scales for the catalog (so that we aren't generating scales larger than the original).
  • [x] Always set sizes appropriately when we use the Image component (so that we don't end up with the largest scale when a smaller one would be sufficient)

sneridagh avatar Nov 24 '25 12:11 sneridagh

@stevepiercy I accepted all the suggestions, but David is working in the backend side, and we might amend them a bit the next days. Thanks!

sneridagh avatar Nov 25 '25 08:11 sneridagh

@sneridagh @davisagli please ping me again for a review when it's done cooking.

stevepiercy avatar Nov 25 '25 08:11 stevepiercy

Can someone else fix the broken links? I'm swamped.

https://github.com/plone/volto/actions/runs/19663404467/job/56314471303?pr=7655

stevepiercy avatar Nov 25 '25 08:11 stevepiercy

@stevepiercy it seems medium added some antibot measures... we cannot do anything about it. How do we proceed with this use cases?

sneridagh avatar Nov 26 '25 07:11 sneridagh

@sneridagh for Medium, ignore the entire domain with a regex in conf.py. There are existing examples. It also needs to be applied to the upstream plone/documentation conf.py.

For the others, fix the links that redirect.

stevepiercy avatar Nov 26 '25 07:11 stevepiercy

@davisagli once https://github.com/plone/plone.volto/pull/205 is merged and released, we can go for this one. We might want to amend the docs with the released p.volto version.

@stevepiercy I amended the docs to reflect the latest changes.

sneridagh avatar Nov 26 '25 09:11 sneridagh