volto icon indicating copy to clipboard operation
volto copied to clipboard

Ebrehault listing block

Open ebrehault opened this issue 1 month ago • 3 comments

Naive implementation.

Comments:

  • The call to collect the items is done directly in apps/seven/app/root.tsx, not sure if that's accurate
  • I have changed the BlocksFormData type as followed:
export type BlocksFormData = ListingBlockFormData | DummyBlockFormData;

That way we can have a specific typing for each type of blocks instead of having one generic interface with a very unhelpful [x: string]: unknown;. DummyBlockFormData is there for now as the other specific block types are not existing yet, but it is meant to be removed once everything is properly typed.


📚 Documentation preview 📚: https://plone-registry--7603.org.readthedocs.build/


📚 Documentation preview 📚: https://volto--7603.org.readthedocs.build/

ebrehault avatar Nov 08 '25 17:11 ebrehault

I changed the base branch to seven instead of main.

davisagli avatar Nov 11 '25 05:11 davisagli

I changed the base branch to seven instead of main.

oops, sorry

ebrehault avatar Nov 12 '25 08:11 ebrehault

I think my PR is ready.

Last questions:

  • not sure why packages/plate/output.css got modified, I did commit it, but not sure I had to
  • when adding catalog dependencies in the different packages with pnpm add react-i18next@catalog: --filter @plone/blocks, I saw pnpm-workspace.yaml was modified automatically. My understanding it should not, because catalog is managed in catalog.json. What is the proper pnpm command?

ebrehault avatar Nov 23 '25 16:11 ebrehault