Ebrehault listing block
Naive implementation.
Comments:
- The call to collect the items is done directly in
apps/seven/app/root.tsx, not sure if that's accurate - I have changed the
BlocksFormDatatype as followed:
export type BlocksFormData = ListingBlockFormData | DummyBlockFormData;
That way we can have a specific typing for each type of blocks instead of having one generic interface with a very unhelpful [x: string]: unknown;.
DummyBlockFormData is there for now as the other specific block types are not existing yet, but it is meant to be removed once everything is properly typed.
📚 Documentation preview 📚: https://plone-registry--7603.org.readthedocs.build/
📚 Documentation preview 📚: https://volto--7603.org.readthedocs.build/
I changed the base branch to seven instead of main.
I changed the base branch to
seveninstead ofmain.
oops, sorry
I think my PR is ready.
Last questions:
- not sure why
packages/plate/output.cssgot modified, I did commit it, but not sure I had to - when adding catalog dependencies in the different packages with
pnpm add react-i18next@catalog: --filter @plone/blocks, I sawpnpm-workspace.yamlwas modified automatically. My understanding it should not, because catalog is managed incatalog.json. What is the proper pnpm command?