WIP: Video block new embed
Replacing the semantic ui embed component with a custom one, to allow for more flexibility especially in regards to accessibility. This does mainly address issues raised in #5731.
Deploy Preview for plone-components canceled.
| Name | Link |
|---|---|
| Latest commit | ab00cfe5dbb57fa38e9bbb5c321716e740ab2a6f |
| Latest deploy log | https://app.netlify.com/sites/plone-components/deploys/67090c5f362aa40008609161 |
@sneridagh should this new component be moved to the volto components package or shall it stay in there core package?
@jackahl LGTM, however, I'd put the component as general available component, in components folder (and, eventually, transfer it to @plone/components, but that's for later, if Volto has to use it right away).
@sneridagh What should be the behavior when someone pass the autoplay:true in video block. Video should start playing automatically when page loads right?
@iRohitSingh please make CI pass too, and solve conflicts.
@jackahl Btw, this probably has to be merged with the work that is almost ready to merge in https://github.com/plone/volto/pull/7318
@jackahl @davisagli Any progress regarding this ?
@iRohitSingh this still needs some work on it to get it correctly working, simplify the source detection syntax and get tests passing. If you have the time to work on that, please do