volto icon indicating copy to clipboard operation
volto copied to clipboard

WIP: Video block new embed

Open jackahl opened this issue 1 year ago • 7 comments

Replacing the semantic ui embed component with a custom one, to allow for more flexibility especially in regards to accessibility. This does mainly address issues raised in #5731.

jackahl avatar Oct 01 '24 09:10 jackahl

Deploy Preview for plone-components canceled.

Name Link
Latest commit ab00cfe5dbb57fa38e9bbb5c321716e740ab2a6f
Latest deploy log https://app.netlify.com/sites/plone-components/deploys/67090c5f362aa40008609161

netlify[bot] avatar Oct 01 '24 09:10 netlify[bot]

@sneridagh should this new component be moved to the volto components package or shall it stay in there core package?

jackahl avatar Oct 01 '24 15:10 jackahl

@jackahl LGTM, however, I'd put the component as general available component, in components folder (and, eventually, transfer it to @plone/components, but that's for later, if Volto has to use it right away).

sneridagh avatar Oct 02 '24 11:10 sneridagh

@sneridagh What should be the behavior when someone pass the autoplay:true in video block. Video should start playing automatically when page loads right?

iRohitSingh avatar Apr 07 '25 11:04 iRohitSingh

@iRohitSingh please make CI pass too, and solve conflicts.

sneridagh avatar Jul 24 '25 13:07 sneridagh

@jackahl Btw, this probably has to be merged with the work that is almost ready to merge in https://github.com/plone/volto/pull/7318

davisagli avatar Sep 08 '25 14:09 davisagli

@jackahl @davisagli Any progress regarding this ?

iRohitSingh avatar Dec 01 '25 08:12 iRohitSingh

@iRohitSingh this still needs some work on it to get it correctly working, simplify the source detection syntax and get tests passing. If you have the time to work on that, please do

jackahl avatar Dec 16 '25 11:12 jackahl