volto icon indicating copy to clipboard operation
volto copied to clipboard

feat: added custom condition to the aria-label user button

Open Wagner3UB opened this issue 1 year ago โ€ข 4 comments

Added a condition to set the aria-label to differentiate the "regular users" from the admin users.

The condition is the same one used inside the 'PersonalTools' component, which opens after the user button is clicked.

Issue with discussion: https://github.com/plone/volto/issues/5119

Wagner3UB avatar Sep 27 '24 11:09 Wagner3UB

Deploy Preview for plone-components canceled.

Name Link
Latest commit 270d7c38e97ac0c9f6722079764223841b0ba063
Latest deploy log https://app.netlify.com/sites/plone-components/deploys/672089c170a3bf0008acc2ff

netlify[bot] avatar Sep 27 '24 11:09 netlify[bot]

@stevepiercy Any idea what's up with the failing ReadTheDocs CI step?

JeffersonBledsoe avatar Oct 14 '24 11:10 JeffersonBledsoe

@sneridagh I'd ignore it as it is for the deleted RTD project, and was probably due to our fiddling around with it, based on the timing.

stevepiercy avatar Oct 14 '24 12:10 stevepiercy

@Wagner3UB Can you change the label to 24 status: ready if there's nothing left to do in this PR?

JeffersonBledsoe avatar Oct 15 '24 19:10 JeffersonBledsoe

Should we remove the messages for Personal Tools, since this PR seems to make it unnecessary?

@Wagner3UB I agree with Steve if we no longer use Personal Tools I would remove it. I would also like to get translations for these 2 new strings at least for the languages that had Personal tools translated. I don't think it's fine for us to replace their translated strings with untranslated english strings. We can always also CC other translators to double-check if what Google Translate or other services suggested we use is accurate.

ichim-david avatar Oct 29 '24 07:10 ichim-david

Hi There! ๐Ÿ‘‹

We haven't seen any activity on this pull request in a while :sleeping:, and we want to make sure that it's still relevant. Please let us know by:

  • adding a comment about what needs to be done next ๐Ÿ’ฌ
  • updating its status and other labels ๐Ÿท๏ธ

Otherwise close this pull request. ๐Ÿงน

github-actions[bot] avatar Apr 28 '25 00:04 github-actions[bot]