volto icon indicating copy to clipboard operation
volto copied to clipboard
verified publisher icon plone

fixes issue #6283 and #6300

Open viveak910 opened this issue 1 year ago • 7 comments

Fixed issue https://github.com/plone/volto/issues/6283 with proxy requests not setting X-Real-IP, X-Forwarded-For, and X-Forwarded-Host headers correctly.

viveak910 avatar Sep 26 '24 12:09 viveak910

Deploy Preview for plone-components canceled.

Name Link
Latest commit e499f034bfe30e26dc5142de3e778b1acf41de82
Latest deploy log https://app.netlify.com/sites/plone-components/deploys/67645d155c97bf000832a3d3

netlify[bot] avatar Sep 26 '24 12:09 netlify[bot]

Could someone take a look when they get a chance? Let me know if anything needs to be changed or if it’s good to go! 🙌

viveak910 avatar Sep 26 '24 15:09 viveak910

yeah got it @stevepiercy

viveak910 avatar Sep 27 '24 17:09 viveak910

@viveak910 did you run tests locally? Please take care. See https://6.docs.plone.org/volto/contributing/testing.html and https://6.docs.plone.org/volto/contributing/acceptance-tests.html

stevepiercy avatar Sep 27 '24 21:09 stevepiercy

@djay @JeffersonBledsoe could you review this, please?

sneridagh avatar Oct 02 '24 11:10 sneridagh

Hi, everyone. I’m new to this process, and I wanted to check if my PR has been merged or just approved. Should I close the PR myself now that the changes have been approved, or will someone else handle it? Thanks!

viveak910 avatar Oct 05 '24 02:10 viveak910

@viveak910 a member of the Volto Team will merge the PR. Please do not close and reopen the PR, as each action sends a notification to all subscribers, needlessly spamming them and making them grumpy.

stevepiercy avatar Oct 05 '24 03:10 stevepiercy