volto icon indicating copy to clipboard operation
volto copied to clipboard

fix: Listing block default summary should use ul tag for its listing

Open ana-oprea opened this issue 1 year ago โ€ข 7 comments

This PR continues the work from PR #4994, which is now outdated. To ensure progress on the development, I've opened this new PR to carry the changes forward and address any remaining tasks or updates.

ana-oprea avatar Sep 25 '24 08:09 ana-oprea

Deploy Preview for plone-components canceled.

Name Link
Latest commit a2f6a281f4844c51e9a45882c1f20d942fbf8c9d
Latest deploy log https://app.netlify.com/sites/plone-components/deploys/66f52e549a8bf800080b2b7c

netlify[bot] avatar Sep 25 '24 08:09 netlify[bot]

@plone/volto-accessibility we need to have a look at this change and provide feedback

ichim-david avatar Sep 25 '24 13:09 ichim-david

@JeffersonBledsoe never mind the review request there needs to be some changes done to this pull request, one of them being not reintroducing Semantic-ui component within the Summary Template

ichim-david avatar Sep 25 '24 15:09 ichim-david

@ana-oprea there are a couple of issues currently:

  1. the listing gets empty p tag even when no content is found (no description added for item)
  2. the listing also affects the coloring which might only be of importance for editors and otherwise confusing for anon users and wonder why there are blue or black titles
  3. it's using again semantic ui react which we want to avoid adding back into core and would be better to use simple html elements
  4. It's fair that we should avoid using headings for the listing even though classic uses h2, it should be something like .listing-header

review-state classic-summary-view

ichim-david avatar Sep 25 '24 15:09 ichim-david

@ana-oprea Thanks for removing SemanticUI fromt here! However, I won't remove the current .ui.list CSS, since you could break a lot of projects out there. Just add the new one instead. Also, we need an upgrade guide entry since it's a breaking change in HTML of the component.

sneridagh avatar Oct 03 '24 09:10 sneridagh

Hi There! ๐Ÿ‘‹

We haven't seen any activity on this pull request in a while :sleeping:, and we want to make sure that it's still relevant. Please let us know by:

  • adding a comment about what needs to be done next ๐Ÿ’ฌ
  • updating its status and other labels ๐Ÿท๏ธ

Otherwise close this pull request. ๐Ÿงน

github-actions[bot] avatar Apr 03 '25 00:04 github-actions[bot]

@plone/volto-accessibility If this could have another look now that SemanticUI is not in there anymore it would be great.

pnicolli avatar May 20 '25 09:05 pnicolli