fix: Listing block default summary should use ul tag for its listing
This PR continues the work from PR #4994, which is now outdated. To ensure progress on the development, I've opened this new PR to carry the changes forward and address any remaining tasks or updates.
Deploy Preview for plone-components canceled.
| Name | Link |
|---|---|
| Latest commit | a2f6a281f4844c51e9a45882c1f20d942fbf8c9d |
| Latest deploy log | https://app.netlify.com/sites/plone-components/deploys/66f52e549a8bf800080b2b7c |
@plone/volto-accessibility we need to have a look at this change and provide feedback
@JeffersonBledsoe never mind the review request there needs to be some changes done to this pull request, one of them being not reintroducing Semantic-ui component within the Summary Template
@ana-oprea there are a couple of issues currently:
- the listing gets empty p tag even when no content is found (no description added for item)
- the listing also affects the coloring which might only be of importance for editors and otherwise confusing for anon users and wonder why there are blue or black titles
- it's using again semantic ui react which we want to avoid adding back into core and would be better to use simple html elements
- It's fair that we should avoid using headings for the listing even though classic uses h2, it should be something like .listing-header
@ana-oprea Thanks for removing SemanticUI fromt here! However, I won't remove the current .ui.list CSS, since you could break a lot of projects out there.
Just add the new one instead. Also, we need an upgrade guide entry since it's a breaking change in HTML of the component.
Hi There! ๐
We haven't seen any activity on this pull request in a while :sleeping:, and we want to make sure that it's still relevant. Please let us know by:
- adding a comment about what needs to be done next ๐ฌ
- updating its status and other labels ๐ท๏ธ
Otherwise close this pull request. ๐งน
@plone/volto-accessibility If this could have another look now that SemanticUI is not in there anymore it would be great.