volto icon indicating copy to clipboard operation
volto copied to clipboard

Add missing for-attribute

Open Gomez opened this issue 1 year ago • 4 comments

We had an a11y audit, these improvements were noted.

Gomez avatar Aug 12 '24 09:08 Gomez

Deploy Preview for plone-components canceled.

Name Link
Latest commit c7f28a5fc1539aa1859b0107b94844bf3372cad4
Latest deploy log https://app.netlify.com/sites/plone-components/deploys/66f271b2bcab080008a5df7a

netlify[bot] avatar Aug 12 '24 09:08 netlify[bot]

@plone/volto-accessibility Needs review

JeffersonBledsoe avatar Aug 12 '24 10:08 JeffersonBledsoe

The failing changelog check is a lie, and can be ignored. See https://github.com/plone/volto/pull/6232.

The failing tests, however, cannot be ignored and must pass. I restarted them in case it was flaky and temporary.

stevepiercy avatar Aug 12 '24 11:08 stevepiercy

Thanks @ichim-david! This is a useful comment, i removed the duplication.

Changelog updated with @stevepiercy comments.

Gomez avatar Aug 23 '24 07:08 Gomez

@Gomez I'll work on this tomorrow as part of the Salamina sprint.

ichim-david avatar Sep 23 '24 13:09 ichim-david