volto icon indicating copy to clipboard operation
volto copied to clipboard

Icon view from Object browser is missing logic to introduce disabled class

Open ichim-david opened this issue 1 year ago • 2 comments

In pull request https://github.com/plone/volto/pull/6054 we received a new object browser view (Icon View)

In the list view which was the previous default if you had an image block on a non image such as a link content type that item is displayed with a list tag with the class disabled. See: choose-image-disabled

This is how the Icon view shows the link content type: current-album-behavior

Adding the disabled class to the icon view list tag would make the listing look like: adding-disabled-class

ichim-david avatar Jun 10 '24 12:06 ichim-david

@ichim-david I've identified a way to improve the Icon View in the object browser. We can add a 'disabled' class to non-image items, similar to how it's done in the List View. This would involve modifying the IconViewItem component to check the item type and apply the class accordingly. It's a small change that will enhance visual consistency across views. Would you like me to proceed with implementing this enhancement?

KUNDAN1334 avatar Aug 06 '24 03:08 KUNDAN1334

@KUNDAN1334 please read and follow First-time contributors, especially Things not to do, Contributing to Plone, and Contributing to Volto.

Also it is not necessary to use AI-generated text when making comments. It adds nothing to the discussion, repeating what has already been stated.

stevepiercy avatar Aug 06 '24 04:08 stevepiercy

Hi There! 👋

We haven't seen any activity on this issue in a while :sleeping:, and we want to make sure that it's still relevant.

If updating to the latest version of Volto doesn't help, please let us know by:

  • adding a comment about what needs to be done next 💬
  • updating its status and other labels 🏷️

Otherwise close this issue. 🧹

github-actions[bot] avatar Mar 27 '25 00:03 github-actions[bot]