volto icon indicating copy to clipboard operation
volto copied to clipboard

Cypress replaced wait with assertions

Open ichim-david opened this issue 2 months ago • 2 comments

After looking at the videos from this playlist https://www.youtube.com/playlist?list=PLP9o9QNnQuAYfFNgCWIxzRVdomGINKhH9 I learned that it's better to use assertions in order to wait for items to show up rather than use wait timeouts in seconds as the assertions can wait up to the default timeout.

I modified some of the flaky tests from block-listing and locking for the editors that @wesleybl was also flagged as being bothersome.

  • Introduced typeWithDelay as I've noticed that if we add the delay of 20ms per typing it avoids selecting other things rather then the slate input and when typing it's less likely to turn an error.

ichim-david avatar May 01 '24 18:05 ichim-david

Deploy Preview for plone-components canceled.

Name Link
Latest commit cfd99667413f964310387067b9c65289bd7cbbad
Latest deploy log https://app.netlify.com/sites/plone-components/deploys/66328ada9506260008cab1c8

netlify[bot] avatar May 01 '24 18:05 netlify[bot]

Deploy Preview for volto canceled.

Name Link
Latest commit cfd99667413f964310387067b9c65289bd7cbbad
Latest deploy log https://app.netlify.com/sites/volto/deploys/66328ada4c0b3900087c4d18

netlify[bot] avatar May 01 '24 18:05 netlify[bot]

Thanks!

wesleybl avatar May 06 '24 13:05 wesleybl