volto icon indicating copy to clipboard operation
volto copied to clipboard

Allow Makefile to be modified by Makefile.local if present

Open ichim-david opened this issue 1 year ago • 4 comments

This way we can modify any of the makefile commands or add extra without having to touch the Volto core file.

ichim-david avatar May 01 '24 14:05 ichim-david

Deploy Preview for plone-components canceled.

Name Link
Latest commit 2caf26007c9183f59fe9490f59083f662093638c
Latest deploy log https://app.netlify.com/sites/plone-components/deploys/66327dd4a4ffeb0008e5ab1f

netlify[bot] avatar May 01 '24 14:05 netlify[bot]

Deploy Preview for volto canceled.

Name Link
Latest commit 2caf26007c9183f59fe9490f59083f662093638c
Latest deploy log https://app.netlify.com/sites/volto/deploys/66327dd4fe3d150008cff28c

netlify[bot] avatar May 01 '24 14:05 netlify[bot]

@ichim-david if it's not present it does not complain? If so, I'd add also ../../../Makefile.local, for make it work with the projectless setups.

sneridagh avatar May 01 '24 17:05 sneridagh

@ichim-david if it's not present it does not complain? If so, I'd add also ../../../Makefile.local, for make it work with the projectless setups.

@sneridagh yes it doesn't complain if it's not present, I've tested the make with and without the file and it works as usual.

You will see a warning locally if you override commands but this is correct as I am overriding the setup command with my own and it just tells me about it. Makefile.local:2: warning: overriding commands for target `setup'

Makefile:101: warning: ignoring old commands for target `setup'

ichim-david avatar May 01 '24 17:05 ichim-david