volto icon indicating copy to clipboard operation
volto copied to clipboard

Pastanaga Editor: Issues found

Open sneridagh opened this issue 6 years ago • 6 comments

UX issues detected by Albert.

  • [x] Title focused, press tab. The field focus stays in the Title, but the cursor changed to the Description tile. You start typing and the cursor stays in the first position, while the text flows (weird already detected behavior).

  • [x] You write two sentences, move to a position in the middle, (to break the in two paragraphs), press enter. I would expect that the rightmost part moved to a new tile below.

  • [x] Given al already existing paragraph, if I position myself in the first position and press backspace. The expected behavior would be that the current tile gets merged with the upper one (if any)

  • [x] Given a paragraph, if I position the cursor in the middle and press shift-enter, I would expect to insert a <br />

  • [x] If I select a text and press cmd-b or cmd-i I would expect to add bold or italics, same for other keymaps, review them.

  • [x] Creating a list, in order to change of line and create a paragraph again in the same tile, after the list. Now it has a bug that creates the paragraph inside the list element.

  • [ ] Ability to create a tile using the default handler (questionable)

  • [ ] Keymaps Shortcuts: cmd-k select the current cursor link, Header cmd-alt-1, subheader cmd-alt-2, quote cmd-alt-5

  • [ ] Markdown shortcuts - if you write * + space a list should be created

  • [ ] Same for 1. + space si escrius 1. For ordered lists

  • [ ] shortcut cmd+o opens the upload image dialog

  • [ ] Autoembeds: video and image or videos URLs, same for Twitter cards

  • [ ] Focus on new tile menu, can’t tabulate to the buttons

  • [X] I can navigate via cursors (done)

  • [ ] I also can navigate to images with cursors, and on image focus, if I press delete, the tile deletes

  • [ ] Undo i Redo support via keymap cmd-z

  • [ ] Given a selected image, pressing left right would change the image align

  • [x] On new tiles the link does not show when set, nevertheless the link is there and if saved it shows on edit again. External links support.

  • [ ] Magic link feature on http/https strings

  • [ ] If volto.com is written and I select it, mark as link, I would expect it to be auto transformed in link (related with the previous one)

sneridagh avatar Jan 24 '19 18:01 sneridagh

On new tiles the link does not show when set, nevertheless the link is there and if saved it shows on edit again. External links support.

@sneridagh It looks like forcing focus has side effects. See https://github.com/draft-js-plugins/draft-js-plugins/issues/800 and a workaround https://github.com/plone/volto/commit/fbde505137552bbe456629d0cc886a09bf7cb611#diff-6da14e6f57d40f6ab56474dbab0ef64dR142

avoinea avatar May 14 '20 15:05 avoinea

Woot! Did you try it out? If we solve this one would be one of the unresolved biggies!

/cc @tisto

sneridagh avatar May 14 '20 18:05 sneridagh

@sneridagh Yes, it works! :tada:

avoinea avatar May 14 '20 18:05 avoinea

@avoinea crap! I backported it to master to take a look, but it's not working for me :( any other change you made in your branch that could be triggering that it works?

sneridagh avatar May 15 '20 06:05 sneridagh

@avoinea doh! I put it in the wrong lifecycle method! I set it in all lifecycle where it was defined, just in case.

Do you mind if I merge the change in another PR? All props to you, of course!

sneridagh avatar May 15 '20 07:05 sneridagh

Links issue fixed by: https://github.com/plone/volto/pull/1489

sneridagh avatar May 16 '20 12:05 sneridagh