volto icon indicating copy to clipboard operation
volto copied to clipboard

Displays validation error messages on control panel forms

Open wesleybl opened this issue 1 year ago • 9 comments

Fixes: #5274

Now the error is displayed:

download (13)

To works properly, it needs: https://github.com/plone/plone.restapi/pull/1771

But it can be merged separately without any problems.

wesleybl avatar Apr 05 '24 19:04 wesleybl

Deploy Preview for volto canceled.

Name Link
Latest commit 63a7238b7a83bab23d2f028e2412c04b730a1285
Latest deploy log https://app.netlify.com/sites/volto/deploys/663155ebd8ef6100082af817

netlify[bot] avatar Apr 05 '24 19:04 netlify[bot]

Deploy Preview for plone-components canceled.

Name Link
Latest commit e250677cddd3eadb3f94a090f3104d8cefddd297
Latest deploy log https://app.netlify.com/sites/plone-components/deploys/66ad230371592e0008c6ab50

netlify[bot] avatar Apr 05 '24 19:04 netlify[bot]

@ichim-david I ran into the error in the "As editor, I can unlock a locked page" test again. I remember you found a solution to the problem:

https://github.com/plone/volto/pull/5933#issuecomment-2029319339

Do you intend to make this fixe?

wesleybl avatar Apr 30 '24 20:04 wesleybl

Could you resolve the merge conflict?

@davisagli done.

wesleybl avatar Apr 30 '24 20:04 wesleybl

@ichim-david I ran into the error in the "As editor, I can unlock a locked page" test again. I remember you found a solution to the problem:

#5933 (comment)

Do you intend to make this fixe?

@wesleybl yup I do ... time to dust up the old pull request I didn't add, April was not a good month for Volto work unlike March :)

ichim-david avatar May 01 '24 06:05 ichim-david

@ichim-david I ran into the error in the "As editor, I can unlock a locked page" test again. I remember you found a solution to the problem:

#5933 (comment)

Do you intend to make this fixe?

@wesleybl only left it there for 1 month .. if you would like to test it locally the locking test here is the pull request where I made the changes necessary to avoid errors after running it 20 times in a row as I've given you the comment on how todo it https://github.com/plone/volto/pull/5998

ichim-david avatar May 01 '24 18:05 ichim-david

@davisagli @sneridagh can you take a look please?

wesleybl avatar May 15 '24 15:05 wesleybl

@wesleybl what's left of this one?

sneridagh avatar May 27 '24 10:05 sneridagh

@wesleybl what's left of this one?

@sneridagh I think it's ready to merge. There was a conflict but I resolved it.

wesleybl avatar May 27 '24 18:05 wesleybl

@sneridagh I answered your questions. Can you take another look please?

wesleybl avatar Jul 11 '24 14:07 wesleybl