volto
volto copied to clipboard
Published
20 hours ago •
plone
plone
Add open/copy target in object browser widget.
Deploy Preview for volto canceled.
| Name | Link |
|---|---|
| Latest commit | 9c80c1f813b5c773b3024776a7e6eaf54fa3addd |
| Latest deploy log | https://app.netlify.com/sites/volto/deploys/660c1a7925580100082ec313 |
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Deploy Preview for plone-components canceled.
| Name | Link |
|---|---|
| Latest commit | 9c80c1f813b5c773b3024776a7e6eaf54fa3addd |
| Latest deploy log | https://app.netlify.com/sites/plone-components/deploys/660c1a7908975900082c2eaf |
Looking at this screenshot that I took of the feature,
@robgietema I suggest the following:
- [ ] remove the title before the link, it's duplicated and doesn't serve a better purpose than the linked text that follows it especially when you have an external link where you get the svg with the external icon.
- [ ] I think a button would be better for the copy link action, right now I feel it needs at a minimum the css pointer cursor added
- [ ] You don't really have any indicator of popup functionality and it's not keyboard accessible but maybe you envision this only as a helper for editors who know that they need this
EDIT: This is an opinion of mine and not a review, feel free todo what you want with it :).
