volto icon indicating copy to clipboard operation
volto copied to clipboard

fix reordering of slots function

Open steffenri opened this issue 1 year ago • 3 comments

steffenri avatar Mar 05 '24 12:03 steffenri

Deploy Preview for plone-components canceled.

Name Link
Latest commit 385081e8a455dc866985082b496349dd838c7b62
Latest deploy log https://app.netlify.com/sites/plone-components/deploys/65e9f4143fcdef0008686d5e

netlify[bot] avatar Mar 05 '24 12:03 netlify[bot]

Deploy Preview for volto canceled.

Name Link
Latest commit 385081e8a455dc866985082b496349dd838c7b62
Latest deploy log https://app.netlify.com/sites/volto/deploys/65e9f4148b55290008fde7a2

netlify[bot] avatar Mar 05 '24 12:03 netlify[bot]

@steffenri that would need a test... and understand why the existing ones pass :)

sneridagh avatar Mar 05 '24 12:03 sneridagh

@sneridagh Added more tests for all the use cases to show what the problem is. Also fixed the cause of the problem. There might be a better way to do this though.

steffenri avatar Mar 07 '24 16:03 steffenri

@davisagli do you know if we can simplify this?

sneridagh avatar Mar 12 '24 15:03 sneridagh