volto icon indicating copy to clipboard operation
volto copied to clipboard
verified publisher icon plone

LeadImage Edit.jsx is still setting aspectRatio that was removed from Image block

Open ichim-david opened this issue 1 year ago • 1 comments

Aspect ratio set on the image block came from this pull request https://github.com/plone/volto/pull/3337/files#diff-bf90a1811efabb5f0f702fc64d57c05efa2cdc30e1ad6a8930dea7267f8683fd This was later deemed a problem https://github.com/plone/volto/issues/5096 and removed in this pull request https://github.com/plone/volto/pull/5278/files

LeadImage/Edit.jsx still sets the aspect ratio which should be removed to keep things consistent: https://github.com/plone/volto/blob/main/packages/volto/src/components/manage/Blocks/LeadImage/Edit.jsx#L118-L120 https://github.com/plone/volto/blob/4de0ce2ff115d709a0a1aa41d5c1031b324114c3/packages/volto/src/components/manage/Blocks/LeadImage/LeadImageSidebar.jsx#L106-L108

ichim-david avatar Feb 28 '24 15:02 ichim-david

@pnicolli @sneridagh do we need to have a different aspect ratio for leadImage on edit or is this a bug as I think it is?

ichim-david avatar Feb 28 '24 15:02 ichim-david