volto icon indicating copy to clipboard operation
volto copied to clipboard

issue-5452 markdown shortcut

Open kHAPPY2004 opened this issue 2 years ago • 7 comments

Fixes #5452 Fixes automarkup shortcut bug for heading and blockquote

kHAPPY2004 avatar Dec 05 '23 19:12 kHAPPY2004

Deploy Preview for volto canceled.

Name Link
Latest commit 19298266e665821e5919c376c86062da5bf2f863
Latest deploy log https://app.netlify.com/sites/volto/deploys/6639eda0c81c0100096c6ec0

netlify[bot] avatar Dec 05 '23 19:12 netlify[bot]

@kHAPPY2004 do not open and close multiple pull requests for the same issue. See item 3: https://6.docs.plone.org/contributing/first-time.html#things-not-to-do

stevepiercy avatar Dec 05 '23 23:12 stevepiercy

Hi @stevepiercy, sorry for making multiple pull request. I have improved the changelog, please verify and let me know if i have done it correctly this time.

kHAPPY2004 avatar Dec 06 '23 18:12 kHAPPY2004

@kHAPPY2004 are you familiar with Cypress tests? Do you imagine to create one for the fix (and for other markdown feature)?

sneridagh avatar Dec 18 '23 10:12 sneridagh

@kHAPPY2004 more information about Cypress, which Volto uses for Acceptance testing.

stevepiercy avatar Dec 18 '23 10:12 stevepiercy

@kHAPPY2004 are you familiar with Cypress tests? Do you imagine to create one for the fix (and for other markdown feature)?

@sneridagh No I am not familiar with cypress yet...

kHAPPY2004 avatar Dec 20 '23 15:12 kHAPPY2004

Deploy Preview for plone-components canceled.

Name Link
Latest commit f30fa6b53eef9704331c733e76e108105a3e071e
Latest deploy log https://app.netlify.com/sites/plone-components/deploys/667086fb8178db0008f9e115

netlify[bot] avatar Jan 08 '24 17:01 netlify[bot]

@sneridagh If this works and I assume it works since Tiberiu and Razvan accepted the work I think we can live with merging this fix without having a test in order to get this over with.

ichim-david avatar Jun 17 '24 18:06 ichim-david