plone
onFocus function to handle block selection
Having focus on the block now is equivalent to clicking on it. Now the block becomes active when focused
To solve this issue: https://github.com/plone/volto/issues/5204
https://github.com/plone/volto/assets/60133113/5410aa64-c4e9-42b0-bb09-190704477322
Deploy Preview for volto canceled.
| Name | Link |
|---|---|
| Latest commit | 7b635fdf156db4d4629199eebeb72cbea41a5419 |
| Latest deploy log | https://app.netlify.com/sites/volto/deploys/65c1de27a78b7e0009e583b7 |
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
@Wagner3UB @giuliaghisini did you have tested this thoroughly in your projects? No side effects? Also in other "bigger" blocks.
@sneridagh @giuliaghisini I just ran some tests on our product, and the only behavior I observed was the expected one, specifically the activation of the blocks, I did not find side effects.
@sneridagh I'm having an issue with a cypress test on the "Blocks-copypaste.js" component. Looks like the test misses "#toolbar-delete-blocks". I tried to find this element on the page but, nothing.
To be honest, I don't remember a toolbar for canceling blocks, but I might be missing something.
"#toolbar-delete-blocks
@Wagner3UB the delete button is visible when you have multiple blocks selected, have a look at this screenshot
Deploy Preview for plone-components canceled.
| Name | Link |
|---|---|
| Latest commit | 4fc3fe3934cab0baf530fb775b918e3d418bd824 |
| Latest deploy log | https://app.netlify.com/sites/plone-components/deploys/669cb3d0766976000894e8e2 |
@sneridagh @ichim-david Piero and I ran some tests, and locally, we didn't find any issues. The Cypress tests didn't show us any problems. Besides that, I did not change the test 'Blocks-copypaste.js' or the component 'BlocksToolbar.jsx'.
We've run out of possibilities.
cc:/ @pnicolli