volto icon indicating copy to clipboard operation
volto copied to clipboard

(Fix): Sorting Order and Sorting On are not working in Search Block edit mode

Open dobri1408 opened this issue 2 years ago • 3 comments

screen-capture.webm

dobri1408 avatar Oct 03 '23 09:10 dobri1408

Deploy Preview for volto ready!

Name Link
Latest commit 75579a71586a4f591cff1ddce8b129eaa9c54517
Latest deploy log https://app.netlify.com/sites/volto/deploys/65eff03d4dece8000899738d
Deploy Preview https://deploy-preview-5262--volto.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Oct 03 '23 09:10 netlify[bot]

Deploy Preview for plone-components canceled.

Name Link
Latest commit 75579a71586a4f591cff1ddce8b129eaa9c54517
Latest deploy log https://app.netlify.com/sites/plone-components/deploys/65eff03d0d6ca8000899b9c7

netlify[bot] avatar Feb 26 '24 17:02 netlify[bot]

Hi @sneridagh, the PR is ready for review. In this PR, I have solved the following two problems: if you are on edit, and you have a preexistent search block ( so not created in this instance), and you are clicking on the reversed order, or sort on, the search results are not updated. This is because on the edit, there is a function called onTriggerSearch, that before didn't receive any parameters. I have also included a test.

dobri1408 avatar Feb 28 '24 07:02 dobri1408

@dobri1408 I've tested your work and indeed the sorting works now when selecting a sort option. I would like for you to also take into consideration that if you select "No selection" there is no call to querystring search to get the preview of this query without any sort options passed. When you save you will see different results from the edit page since the sorting option changed. Once that is treated if it can be treated we are good to go

ichim-david avatar Mar 08 '24 10:03 ichim-david

Hi @ichim-david I have implemented what you have asked.

dobri1408 avatar Mar 12 '24 07:03 dobri1408

@sneridagh Can you please take a look on this one and if merge, please backport also to 16.x.

Thank you!

avoinea avatar Mar 12 '24 14:03 avoinea