volto icon indicating copy to clipboard operation
volto copied to clipboard

Refactor UndoControl Panel

Open Tishasoumya-02 opened this issue 2 years ago • 10 comments

#4460

Tishasoumya-02 avatar Aug 04 '23 09:08 Tishasoumya-02

Deploy Preview for volto canceled.

Name Link
Latest commit 4bc423d4ca4a0ecd964026f31af0d4beded80049
Latest deploy log https://app.netlify.com/sites/volto/deploys/64d64ad173504100078dc404

netlify[bot] avatar Aug 04 '23 09:08 netlify[bot]

Passing run #6814 ↗︎

0 553 20 0 Flakiness 0

Details:

storybook update
Project: Volto Commit: 4bc423d4ca
Status: Passed Duration: 16:12 💡
Started: Aug 11, 2023 2:54 PM Ended: Aug 11, 2023 3:10 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

cypress[bot] avatar Aug 04 '23 09:08 cypress[bot]

@Tishasoumya-02 the number of changed files is over 3000. Something doesn't seem right in this PR. It may be easier to start with a new PR from main with only the changes you want.

stevepiercy avatar Apr 25 '25 21:04 stevepiercy

@stevepiercy I don't know what you're seeing. I only see 4 changed files.

davisagli avatar Apr 25 '25 21:04 davisagli

@davisagli weird. I guess I hit GitHub while it was churning through the diff. It displayed a that warning of a 3000 file limit, and the left nav expanded to show thousands of files. Now it just shows 4.

stevepiercy avatar Apr 25 '25 21:04 stevepiercy

@Tishasoumya-02 needs some lint and prettier. Also check that the change log is in the right place. https://github.com/plone/volto/actions/runs/14668097934/job/41167838378?pr=5057

stevepiercy avatar Apr 25 '25 21:04 stevepiercy

@stevepiercy yes , still working on this will make the changes.

Tishasoumya-02 avatar Apr 27 '25 08:04 Tishasoumya-02

@stevepiercy, PR good to be reviewed again!

Tishasoumya-02 avatar Apr 27 '25 09:04 Tishasoumya-02

@pnicolli I added this item to https://github.com/orgs/plone/projects/19.

stevepiercy avatar Apr 27 '25 10:04 stevepiercy

@Tishasoumya-02 can you take a look at what @wesleybl is saying? Thanks!

sneridagh avatar Jun 22 '25 15:06 sneridagh