volto icon indicating copy to clipboard operation
volto copied to clipboard

Accessibility tests in CMS-UI

Open Wagner3UB opened this issue 2 years ago • 3 comments

Initial tests inside Cypress for keyboard accessibility.

This is a minimal part of the hole and long process. So far, we have conducted a test to replicate the behavior of a user inside the CMS-UI after creating a new component "news item", where the user modifies a content and save it using only the keyboard. In this process, we had fixed some A11Y problems:

  • Now it is possible to leave the text block using the Tab key.
  • Slate text containers re-arranged to give the tab a proper path (text input → drag & drop button → delete button)
  • Added a general ":focus-visible" to standardize the focus within the application.
  • small a11y general fixes

@sneridagh We want to know two things:

  • We have created a new folder to run the accessibility test, but we are not sure if this is the right approach.
  • The idea is merge these small parts separately or do more work and merge all at once.

Wagner3UB avatar May 19 '23 15:05 Wagner3UB

Deploy Preview for volto canceled.

Name Link
Latest commit 0f6523311fb30cfb6b3c9b5c69748bf4c443560c
Latest deploy log https://app.netlify.com/sites/volto/deploys/646794d2c8ccf2000808aa18

netlify[bot] avatar May 19 '23 15:05 netlify[bot]

Passing run #5221 ↗︎

0 493 20 0 Flakiness 0

Details:

Merge branch 'master' into a11y-edit-accessibility-tests
Project: Volto Commit: 0f6523311f
Status: Passed Duration: 13:58 💡
Started: May 19, 2023 3:28 PM Ended: May 19, 2023 3:42 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

cypress[bot] avatar May 19 '23 15:05 cypress[bot]

@Wagner3UB all good for me, go ahead with the current implementation.

If it's possible do not introduce changes in the formatting of the less files (take a look at the diffs) probably an IDE formatter run on them and introduced some formatting changes along with legit ones. It's better to group them all in the same PR (if any). Also, these ones were intended, so not much of value in this PR.

Thanks for taking care! Please continue and let me know the outcome and the status.

sneridagh avatar Jul 16 '23 16:07 sneridagh