volto icon indicating copy to clipboard operation
volto copied to clipboard
verified publisher icon plone

4580 it should be possible to open linked items in a new tab

Open falgunmpatel opened this issue 2 years ago • 13 comments

Added an anchor tag, targeting a blank page.

falgunmpatel avatar Mar 23 '23 08:03 falgunmpatel

Deploy Preview for volto canceled.

Name Link
Latest commit c683846eea5af404c1c93ddb60e8db6edae03b99
Latest deploy log https://app.netlify.com/sites/volto/deploys/64562bb03b4e600008106297

netlify[bot] avatar Mar 23 '23 08:03 netlify[bot]

Passing run #5068 ↗︎

0 493 20 0 Flakiness 0

Details:

Merge branch 'master' into 4580-it-should-be-possible-to-open-linked-items-in-a-...
Project: Volto Commit: c683846eea
Status: Passed Duration: 12:49 💡
Started: May 6, 2023 10:31 AM Ended: May 6, 2023 10:44 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

cypress[bot] avatar Mar 23 '23 09:03 cypress[bot]

~~This could be that your authentication expired. We have not updated permissions since you pushed the original commit to this branch and repo. This has happened to me in the past when using PyCharm, and I had to purge some old authentication tokens to get it to let me push again.~~

Edit

After more careful examination, the commits were pushed to a branch of volto, then permissions were restricted, and now new commits cannot be pushed to this branch by its creator.

stevepiercy avatar Mar 25 '23 19:03 stevepiercy

This could be that your authentication expired. We have not updated permissions since you pushed the original commit to this branch and repo. This has happened to me in the past when using PyCharm, and I had to purge some old authentication tokens to get it to let me push again.

@stevepiercy I have been moved from team "Developers" to team "Contributors" and therefore maybe I lost those permissions. Please let me know if I have mistaken it.

I am able to propose changes and not commit changes. And I have proposed changes updating news to give myself credit.

falgunmpatel avatar Mar 25 '23 20:03 falgunmpatel

Ah, yes, now I see that you created this branch just before the AI Team implemented the stopgap measure. I've added this to the list of considerations.

stevepiercy avatar Mar 26 '23 06:03 stevepiercy

@falgunmpatel I have given you individual write permissions to this repo so that you can finish the pull request and don't need to restart it on a fork.

As @stevepiercy wrote we had to change some default permissions on ou repositories and change the contribution process for new community members. It will take a bit of time to figure our the correct settings and document them.

After a number of contributions from new members we will grant more permissive access, but we need to discuss the specifics of that as well.

fredvd avatar Mar 27 '23 13:03 fredvd

@falgunmpatel I have given you individual write permissions to this repo so that you can finish the pull request and don't need to restart it on a fork.

As @stevepiercy wrote we had to change some default permissions on ou repositories and change the contribution process for new community members. It will take a bit of time to figure our the correct settings and document them.

After a number of contributions from new members we will grant more permissive access, but we need to discuss the specifics of that as well.

Yes, @fredvd I understand that you have to manage this large inflow of contributions from new contributors due to GSoC 2023. I appreciate your efforts to help me contribute.

Thank You

falgunmpatel avatar Mar 27 '23 16:03 falgunmpatel

Sir @tiberiuichim, Can you please review this request and possibly merge it if everything is alright, so that it doesn't get outdated from the master branch.

Thank You

falgunmpatel avatar Mar 28 '23 20:03 falgunmpatel

@falgunmpatel it's OK if it gets outdated. Core developers can click a button in GitHub to merge master into the PR, or do so locally with git commands, and everything will get updated.

stevepiercy avatar Mar 28 '23 20:03 stevepiercy

@falgunmpatel it's OK if it gets outdated. Core developers can click a button in GitHub to merge master into the PR, or do so locally with git commands, and everything will get updated.

Okay Sir! Thanks for letting me know.

falgunmpatel avatar Mar 28 '23 22:03 falgunmpatel

I think it's okay to open the link in a new tab without showing a hint that that is going to happen. It would be more surprising if it took the editor away from the page they are editing.

But I would put the link around the title only, to reduce the confusion of having a clickable icon inside a clickable link.

davisagli avatar Jun 19 '23 05:06 davisagli

I think it's okay to open the link in a new tab without showing a hint that that is going to happen. It would be more surprising if it took the editor away from the page they are editing.

But I would put the link around the title only, to reduce the confusion of having a clickable icon inside a clickable link.

In an on-going Plone Classic project, where the portal is used by blind people using screen readers, we are requested to signal in the title attribute of the link to mark that the link is going to be opened in a new tab because of a11y reasons.

erral avatar Jun 19 '23 06:06 erral

In an on-going Plone Classic project, where the portal is used by blind people using screen readers, we are requested to signal in the title attribute of the link to mark that the link is going to be opened in a new tab because of a11y reasons.

Okay, that sounds fine. In Volto we could add that in the UniversalLink component whenever target="_blank" unless the title is explicitly overridden.

davisagli avatar Jun 19 '23 06:06 davisagli