volto icon indicating copy to clipboard operation
volto copied to clipboard

Environment variables need to be properly documented

Open tiberiuichim opened this issue 1 year ago • 13 comments

https://github.com/plone/volto/blob/d3865b3ac9e5c1213058373e6ecf5422060d7ab0/src/config/index.js#L91-L93

tiberiuichim avatar Mar 21 '23 07:03 tiberiuichim

Follow the pattern of documenting environment variables as shown in https://6.docs.plone.org/volto/configuration/environmentvariables.html

tiberiuichim avatar Mar 21 '23 07:03 tiberiuichim

Hey @tiberiuichim , I'm interested to work on this. Can you please explain to me in easy, what to change?

KIET7UKE avatar Mar 22 '23 13:03 KIET7UKE

Hi @tiberiuichim, I am Qasim Javed a student of Computing and in the final year of my degree . I have just started looking to contribute for open source . At this stage i am leaning web development and already made many projects on JavaScript and React. I am interested to work on this issue,Can you please help me in the understanding of this issue and assign it to me ?

Your response will be highly appreciated,

Thanks

mjavedcoder avatar Mar 26 '23 16:03 mjavedcoder

@KIET7UKE @Hello-Qasim please see Volto and general contributing guidelines.

  • https://6.docs.plone.org/volto/developer-guidelines/contributing.html
  • https://6.docs.plone.org/contributing/index.html#making-contributions-on-github

I have also updated the issue description, and will hide both of your comments as "resolved" to reduce clutter. If you are still not clear on what needs to be done and how we expect contributors to work in Plone, please ask specific questions. Thank you!

stevepiercy avatar Mar 26 '23 21:03 stevepiercy

As these are runtime variable and as the docs suggest these should be documented like yarn build && RAZZLE_API_PATH=https://plone.org yarn start:prod Right?

harshlancer avatar Mar 29 '23 12:03 harshlancer

hey! i would like to contribute can i get assigned!

AAYUSH-droid avatar Mar 29 '23 17:03 AAYUSH-droid

@AAYUSH-droid see https://github.com/plone/volto/issues/4581#issuecomment-1484224952

stevepiercy avatar Mar 31 '23 07:03 stevepiercy

Can I start working on that issue?

hasnaat-iftikhar avatar May 13 '23 08:05 hasnaat-iftikhar

@hasnaat-iftikhar please read and follow Contributing to Plone and First-time contributors.

stevepiercy avatar May 13 '23 10:05 stevepiercy

Hey @stevepiercy can you guide me a little in this?

Akshat2Jain avatar Sep 25 '23 08:09 Akshat2Jain

@Akshat2Jain sorry, I don't know. I would suggest you look at what @tiberiuichim posted and referenced, and try to figure it out from there, and if it is still not clear, then ask him as he created this issue.

stevepiercy avatar Sep 25 '23 09:09 stevepiercy

I think we need to overhaul this page before we let contributors move forward with a PR. Environment variables

For example, we don't need to refer to obsolete things here, only current things. The obsolete stuff goes into the upgrade guide.

I also would like to have settings in a sorted definition list, instead of headings for each. We can group together some settings in categories under a heading as needed.

@tiberiuichim what do you think?

stevepiercy avatar Feb 06 '24 00:02 stevepiercy

@stevepiercy +1 on your proposal

tiberiuichim avatar Feb 06 '24 06:02 tiberiuichim