volto icon indicating copy to clipboard operation
volto copied to clipboard

Test against Plone 5.2.9 and 6.0.0b1

Open davisagli opened this issue 1 year ago • 7 comments

davisagli avatar Aug 02 '22 05:08 davisagli

Deploy Preview for volto canceled.

Name Link
Latest commit 7f4f7d84c69678914e6b1cf152906e72316a74d5
Latest deploy log https://app.netlify.com/sites/volto/deploys/62fdc5bcd16f8f00082642f0

netlify[bot] avatar Aug 02 '22 05:08 netlify[bot]

@davisagli I also need this for https://github.com/plone/volto/pull/3534, Are the test failures related?

nileshgulia1 avatar Aug 02 '22 06:08 nileshgulia1

I assume the test failures are related and need a closer look. I won't have time this evening.

davisagli avatar Aug 02 '22 06:08 davisagli

I can see some tests that is requiring folders, and I think latest plone.volto removed it from the default set of available content types.

sneridagh avatar Aug 02 '22 08:08 sneridagh

Also, related:

https://github.com/plone/plone.volto/pull/79

This one is important, because the default profiles use slate too. Although tests might dodge this (by not testing on the DX root).

sneridagh avatar Aug 02 '22 08:08 sneridagh

I can see some tests that is requiring folders, and I think latest plone.volto removed it from the default set of available content types.

@sneridagh So I guess we need to update the tests to use folders or documents based on the Plone version?

@nileshgulia1 the empty KGS was intentional (though maybe not exactly correct yet). On Plone 5.2 we need some extra version pins to override the ones from dist.plone.org, but on Plone 6 the ones from dist.plone.org should be adequate. I hope.

davisagli avatar Aug 03 '22 05:08 davisagli

@nileshgulia1 the empty KGS was intentional (though maybe not exactly correct yet). On Plone 5.2 we need some extra version pins to override the ones from dist.plone.org, but on Plone 6 the ones from dist.plone.org should be adequate. I hope.

@davisagli I added it back in 15a8e55, sorry I was assuming this KGS will be overriding the default KGS version pins somewhere.

nileshgulia1 avatar Aug 03 '22 10:08 nileshgulia1

@davisagli @nileshgulia1 I changed the tests, it seemed the most convenient thing to do, if default Plone 6 is not going to have them by default. So we can catch something wrong if Documents are used instead too.

sneridagh avatar Aug 16 '22 14:08 sneridagh



Test summary

345 0 15 0


Run details

Project Volto
Status Passed
Commit 7f4f7d84c6
Started Aug 18, 2022 4:56 AM
Ended Aug 18, 2022 5:09 AM
Duration 13:04 💡
OS Linux Ubuntu - 20.04
Browser Chrome 104

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

cypress[bot] avatar Aug 17 '22 03:08 cypress[bot]

The next one should be flipping from using as base 5.x and use 6 instead, 5.x only essential.

sneridagh avatar Aug 18 '22 07:08 sneridagh

https://github.com/plone/volto/issues/3571

sneridagh avatar Aug 18 '22 07:08 sneridagh