volto
volto copied to clipboard
plone
resolved more-always-show-root-contents issue
Deploy Preview for volto canceled.
| Name | Link |
|---|---|
| Latest commit | 1f1a31f167a6b0663abae07a8909930bf9284e39 |
| Latest deploy log | https://app.netlify.com/sites/volto/deploys/633e95ddd2c9f4000984c401 |
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Test summary
Run details
| Project | Volto |
| Status | Passed |
| Commit | 1f1a31f167 |
| Started | Oct 6, 2022 8:49 AM |
| Ended | Oct 6, 2022 9:03 AM |
| Duration | 13:27 💡 |
| OS | Linux Ubuntu - 20.04 |
| Browser | Chrome 106  |
View run in Cypress Dashboard ➡️
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard
![cypress[bot] avatar](https://avatars.githubusercontent.com/in/9078?v=4 "Published by a pub.dev verified publisher"){kind=small}
Seems that something is borked out in this PR, the GHA do not run...
@sneridagh I see all green now.
I think that @tiberiuichim is right... we cannot place the getContent in the Toolbar... I'll test it later, but if I'm not mistaken, that will trigger a double content call (the one in App and this one.
I'll say we have to move it to the contents component, so it only triggers when it's present.
@MdSahil-oss @tiberiuichim I've moved the re-fetch to Contents. In the meanwhile thanks to @reebalazs and @robgietema, we discovered a thinggy in the Volto routes definitions, I'll create another PR for fixing it.