volto
volto copied to clipboard
i18n for EventDatesInfo
to fix https://github.com/plone/volto/issues/3438
Deploy Preview for volto canceled.
Name | Link |
---|---|
Latest commit | 80173685e3fe76956daf1395b0e3431a9cb0f24d |
Latest deploy log | https://app.netlify.com/sites/volto/deploys/62c2ea1c0dc0230008ff221d |
@mbarde you need to sign the Plone Contributor Agreement in order to merge this pull request.
Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html
I think that this suggestion does not work. I think that we need something with parameters like in Classic UI:
https://github.com/collective/plone.app.locales/blob/master/plone/app/locales/locales/plone.pot#L8866-L8883
@mbarde Yes, we need a full message with params, as @erral is suggesting.
See the example in the docs:
function () {
const messages = defineMessages({
greeting: {
id: 'app.greeting',
defaultMessage: 'Hello, {name}!',
description: 'Greeting to welcome the user to the app',
},
})
return intl.formatMessage(messages.greeting, {name: <b>Eric</b>})
}
at https://formatjs.io/docs/react-intl/api/#formatmessage
Last week I tried unsuccessfully to build such messages trying to keep existing HTML, but it should be possible like @tiberiuichim suggests