volto icon indicating copy to clipboard operation
volto copied to clipboard

display style schema as accordion not tabs

Open danielamormocea opened this issue 2 years ago • 4 comments

related to #3414

Screenshot 2022-06-20 at 17-27-22 Edit Page

danielamormocea avatar Jun 20 '22 14:06 danielamormocea

Deploy Preview for volto canceled.

Name Link
Latest commit e80f5ca75378ea207eb6ac08504e5a2aea3bc8fe
Latest deploy log https://app.netlify.com/sites/volto/deploys/63fe15bf93f9c40008b013eb

netlify[bot] avatar Jun 20 '22 14:06 netlify[bot]

Passing run #4104 ↗︎

0 459 20 0 Flakiness 0

Details:

Merge branch 'master' into accordions
Project: Volto Commit: e80f5ca753
Status: Passed Duration: 09:24 💡
Started: Feb 28, 2023 2:58 PM Ended: Feb 28, 2023 3:07 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

cypress[bot] avatar Jun 20 '22 15:06 cypress[bot]

Screenshot 2022-06-23 at 18-39-09 Edit Page

Screenshot 2022-06-23 at 18-38-47 Edit Page

I added a boolean option named "stylesSchemaTabsView" which can be passed to the Blocks. If it is true, we can have the Styling with tabs, and if it is false, then we have the accordions.

I also talked with Madalina for a view on the UI situation, and she recommended to have the 'Styling' header just like the Block's name header, so it is cleaner and consistent. Also, in the accordions' case, we always have the 'Default' open when we first open the edit view sidebar, and there is just one accordion open at all times, so when we click on "Other" the "Default" closes.

danielamormocea avatar Jun 23 '22 15:06 danielamormocea

This would be a nice addition to the ObjectWidget, but it needs to be framed as an ObjectWidget configuration option, rather then something related to the schema.

tiberiuichim avatar Nov 25 '22 08:11 tiberiuichim