plone
change history route name
Deploy Preview for volto canceled.
| Name | Link |
|---|---|
| Latest commit | f482018fb8f6197d350947f6a9a5c8536a81fda7 |
| Latest deploy log | https://app.netlify.com/sites/volto/deploys/633ea8c3d6c1b400083b5e99 |
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Test summary
Run details
| Project | Volto |
| Status | Passed |
| Commit | f482018fb8 |
| Started | Oct 6, 2022 10:10 AM |
| Ended | Oct 6, 2022 10:22 AM |
| Duration | 12:26 💡 |
| OS | Linux Ubuntu - 20.04 |
| Browser | Chrome 106  |
View run in Cypress Dashboard ➡️
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard
![cypress[bot] avatar](https://avatars.githubusercontent.com/in/9078?v=4 "Published by a pub.dev verified publisher"){kind=small}
@plone/volto-team I guess we should get to an agreement on naming.
Personally, pageHistory is far too specific, because could be the history of other content (eg. event). What about content-history?
Also, what about going back to the @@ notation?
@sneridagh so should I just change the name to "content-history", or should I wait for the discussion's outcome regarding @@ ?
@sneridagh The funny thing is that if you add a page called Sharing it's renamed to sharing-1.
@danielamormocea Can you please investigate what is different within the sharing case and why it doesn't behave the same for history?
Because the issue is more deeper and it doesn't resumo only to History. Try adding a Page called controlpanel
During lunch we decided to go ahwad with the @@ namespace leaving the current route for v16, deprecating it in next version. We change all references to @@ . Does that makes sense to you?
@sneridagh I don't exactly understand what you mean by "We change all references to @@". Should I add some middleware, or I just change all the route names, or maybe there is another way I am not aware of? Some example would really help :) Thanks!
Since the naming of the views is controversial, I'd say we use the same name that Plone has: historyview, and mark it as a Breaking change.
@danielamormocea could you please take care?