volto icon indicating copy to clipboard operation
volto copied to clipboard

consume site_actions from restapi

Open nileshgulia1 opened this issue 2 years ago • 6 comments

Reference: https://github.com/plone/plone.restapi/issues/817 I still think it's nice to have it. Opinions are welcome.

nileshgulia1 avatar Apr 14 '22 12:04 nileshgulia1

Deploy Preview for volto canceled.

Name Link
Latest commit d0bc151799cec429e106efee5f6681220ca4bd04
Latest deploy log https://app.netlify.com/sites/volto/deploys/635c036b1b4c28000862dd68

netlify[bot] avatar Apr 14 '22 12:04 netlify[bot]

The restapi PR: https://github.com/plone/plone.restapi/pull/1076

nileshgulia1 avatar Apr 14 '22 12:04 nileshgulia1

ah, wait we need to have the titles translated.

nileshgulia1 avatar Apr 14 '22 12:04 nileshgulia1

Are you aware that if we do that, without touching anything in GenericSetup, by default it will point to inexistent content/views (but valid in classic) in vanilla Plone?

Like: There is no accessibility-info nor contact-info view in Volto.

We would need a GS amendment in plone.volto

            "site_actions": [
                 {
                     "icon": "",
                     "id": "sitemap",
                     "title": "Site Map"
                     "title": "Site Map",
                     "url": "http://localhost:55001/plone/sitemap"
                 },
                 {
                     "icon": "",
                     "id": "accessibility",
                     "title": "Accessibility"
                     "title": "Accessibility",
                     "url": "http://localhost:55001/plone/accessibility-info"
                 },
                 {
                     "icon": "",
                     "id": "contact",
                     "title": "Contact"
                     "title": "Contact",
                     "url": "http://localhost:55001/plone/contact-info"
                 }
             ],

sneridagh avatar Apr 29 '22 10:04 sneridagh

@sneridagh GS amendment: https://github.com/plone/plone.volto/pull/64

nileshgulia1 avatar Jun 02 '22 11:06 nileshgulia1



Test summary

418 0 20 0


Run details

Project Volto
Status Passed
Commit d0bc151799
Started Oct 28, 2022 4:33 PM
Ended Oct 28, 2022 4:44 PM
Duration 11:30 💡
OS Linux Ubuntu - 20.04
Browser Chrome 106

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

cypress[bot] avatar Jun 30 '22 07:06 cypress[bot]

I think this can be merged now -- it just needs an update to move the changelog entry up to the current release.

@davisagli Fixed.

avoinea avatar Oct 28 '22 16:10 avoinea