volto
volto copied to clipboard
consume site_actions from restapi
Reference: https://github.com/plone/plone.restapi/issues/817 I still think it's nice to have it. Opinions are welcome.
Deploy Preview for volto canceled.
Name | Link |
---|---|
Latest commit | d0bc151799cec429e106efee5f6681220ca4bd04 |
Latest deploy log | https://app.netlify.com/sites/volto/deploys/635c036b1b4c28000862dd68 |
The restapi PR: https://github.com/plone/plone.restapi/pull/1076
ah, wait we need to have the titles translated.
Are you aware that if we do that, without touching anything in GenericSetup, by default it will point to inexistent content/views (but valid in classic) in vanilla Plone?
Like: There is no accessibility-info nor contact-info view in Volto.
We would need a GS amendment in plone.volto
"site_actions": [
{
"icon": "",
"id": "sitemap",
"title": "Site Map"
"title": "Site Map",
"url": "http://localhost:55001/plone/sitemap"
},
{
"icon": "",
"id": "accessibility",
"title": "Accessibility"
"title": "Accessibility",
"url": "http://localhost:55001/plone/accessibility-info"
},
{
"icon": "",
"id": "contact",
"title": "Contact"
"title": "Contact",
"url": "http://localhost:55001/plone/contact-info"
}
],
@sneridagh GS amendment: https://github.com/plone/plone.volto/pull/64
Test summary
Run details
Project | Volto |
Status | Passed |
Commit | d0bc151799 |
Started | Oct 28, 2022 4:33 PM |
Ended | Oct 28, 2022 4:44 PM |
Duration | 11:30 💡 |
OS | Linux Ubuntu - 20.04 |
Browser | Chrome 106 ![]() |
View run in Cypress Dashboard ➡️
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard
I think this can be merged now -- it just needs an update to move the changelog entry up to the current release.
@davisagli Fixed.