volto icon indicating copy to clipboard operation
volto copied to clipboard

Added placeholder param to widget, to change default placeholder

Open giuliaghisini opened this issue 2 years ago • 6 comments

giuliaghisini avatar Jan 19 '22 10:01 giuliaghisini

@giuliaghisini check if the placeholder is available as a control in all the touched widget stories, start storybook with yarn storybook. I think the widgets that define proptypes will have them, but those that don't, won't have them, in which case you should add them as a possible control in the story (maybe even define a custom story for the placeholder option? )

tiberiuichim avatar Jan 19 '22 11:01 tiberiuichim

@giuliaghisini check if the placeholder is available as a control in all the touched widget stories, start storybook with yarn storybook. I think the widgets that define proptypes will have them, but those that don't, won't have them, in which case you should add them as a possible control in the story (maybe even define a custom story for the placeholder option? )

@tiberiuichim i've tested the StoryBook and fixed stories

giuliaghisini avatar Feb 14 '22 15:02 giuliaghisini

Deploy Preview for volto canceled.

Name Link
Latest commit 843322c02593446c8c590a20a098c6cb1e9544dc
Latest deploy log https://app.netlify.com/sites/volto/deploys/6306207a59ae54000ef8f972

netlify[bot] avatar Apr 04 '22 10:04 netlify[bot]

@tiberiuichim @sneridagh

giuliaghisini avatar Apr 04 '22 10:04 giuliaghisini

@tiberiuichim @sneridagh

giuliaghisini avatar May 02 '22 09:05 giuliaghisini



Test summary

347 0 15 0


Run details

Project Volto
Status Passed
Commit 843322c025
Started Aug 24, 2022 1:02 PM
Ended Aug 24, 2022 1:10 PM
Duration 08:28 💡
OS Linux Ubuntu - 20.04
Browser Chrome 104

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

cypress[bot] avatar May 02 '22 09:05 cypress[bot]