plone
Blocks linkintegrity
- registered an adapter to retrieve and set references for an IBlocks enabled content
- add a service "@linkintegrity" that returns a list of potential breaches for the context
The first part populates and keep updated reference catalog also for contents that use blocks.
The second part in my mind should be used in the frontend with a call before delete confirmation, like in the classic Plone interface.
If it's ok for you, i can open an issue in Volto to integrate this endpoint.
btw: as usually i created everything into plone.restapi because it becomes the bunch for all volto stuffs, but probably it's not the best place.
@cekk thanks for creating this Pull Request and help improve Plone!
To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.
Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:
@jenkins-plone-org please run jobs
With this simple comment all the jobs will be started automatically.
Happy hacking!
FYI: we need a conditional import for Plone 4.3: https://travis-ci.org/github/plone/plone.restapi/jobs/692615398
@cekk crap. I somehow totally missed your work on this. That's awesome! We have this requirement in a client project (for both DraftJS and blocks). We have time and budget to look into this in the next weeks/months and the approval from the client to publish our work as open source.
We also still need to talk about the SEO/SSR issue. Do you have time this week for a call about SEO and link integrity? :)
yes, sure: they are on my to-do list too but still doesn't have time for them :(
I'm in for a call..tomorrow morning? Or whenever you want. Ping me on slack.
@tisto we now have the frontend too.
It's not clear to me why i have a failing test on documentation
@tisto could we merge this as well, what do you think? The frontend part is ready too.
Deploy Preview for plone-restapi ready!
| Name | Link |
|---|---|
| Latest commit | 47ae71f484e6c9cd00034ea314854f72e914d0b3 |
| Latest deploy log | https://app.netlify.com/sites/plone-restapi/deploys/633899bffe18670008e30f00 |
| Deploy Preview | https://deploy-preview-953--plone-restapi.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
@tisto Hello :) My PR's tests (https://github.com/plone/volto/pull/3317) are waiting for this merge. What is the status of this PR?
@cekk @danielamormocea sorry sorry sorry folks for letting you down for so long. I finally came around to reviewing and merging this. I owe you both a drink at ploneconf! :)